Merge pull request #84 from jonisavo/remove-thread-critical

Remove all Thread.critical usage from BitmapCache

Data/Scripts/009_Objects and windows/001_BitmapCache.rb

@@ -41,27 +41,19 @@ end
 class WeakRef
   @@id_map =  {}
   @@id_rev_map =  {}
-  @@final = lambda { |id|
+  @@final = lambda do |id|
-    old_thread_status = Thread.critical
+    rids = @@id_map[id]
-    Thread.critical = true
+    if rids
-    begin
+      rids.each { |rid| @@id_rev_map.delete(rid) }
-      rids = @@id_map[id]
+      @@id_map.delete(id)
-      if rids
-	      for rid in rids
-	        @@id_rev_map.delete(rid)
-        end
-        @@id_map.delete(id)
-      end
-      rid = @@id_rev_map[id]
-      if rid
-	      @@id_rev_map.delete(id)
-	      @@id_map[rid].delete(id)
-	      @@id_map.delete(rid) if @@id_map[rid].empty?
-      end
-    ensure
-      Thread.critical = old_thread_status
     end
-  }
+    rid = @@id_rev_map[id]
+    if rid
+      @@id_rev_map.delete(id)
+      @@id_map[rid].delete(id)
+      @@id_map.delete(rid) if @@id_map[rid].empty?
+    end
+  end
 
   # Create a new WeakRef from +orig+.
   def initialize(orig)
@@ -81,17 +73,11 @@ class WeakRef
 
   def __setobj__(obj)
     @__id = obj.__id__
-    old_thread_status = Thread.critical
+    unless @@id_rev_map.key?(self)
-    begin
+      ObjectSpace.define_finalizer obj, @@final
-      Thread.critical = true
+      ObjectSpace.define_finalizer self, @@final
-      unless @@id_rev_map.key?(self)
-        ObjectSpace.define_finalizer obj, @@final
-        ObjectSpace.define_finalizer self, @@final
-      end
-      @@id_map[@__id] = [] unless @@id_map[@__id]
-    ensure
-      Thread.critical = old_thread_status
     end
+    @@id_map[@__id] = [] unless @@id_map[@__id]
     @@id_map[@__id].push self.__id__
     @@id_rev_map[self.__id__] = @__id
   end