Removed all uses of ID numbers for GameDatas BodyColor, BodyShape and Target, removed support for trainer type graphics using ID numbers in their names

Data/Scripts/010_Data/001_Hardcoded data/004_BodyShape.rb

@@ -1,26 +1,25 @@
-# NOTE: The id_number is only used to determine the order that body shapes are
-#       listed in the Pokédex search screen. Number 0 (:None) is ignored; they
-#       start with shape 1.
+# NOTE: The order these shapes are registered are the order they are listed in
+#       the Pokédex search screen.
 #       "Graphics/Pictures/Pokedex/icon_shapes.png" contains icons for these
 #       shapes.
 module GameData
   class BodyShape
     attr_reader :id
-    attr_reader :id_number
     attr_reader :real_name
+    attr_reader :icon_position   # Where this shape's icon is within icon_shapes.png
 
     DATA = {}
 
-    extend ClassMethods
+    extend ClassMethodsSymbols
     include InstanceMethods
 
     def self.load; end
     def self.save; end
 
     def initialize(hash)
-      @id        = hash[:id]
-      @id_number = hash[:id_number] || -1
-      @real_name = hash[:name]      || "Unnamed"
+      @id            = hash[:id]
+      @real_name     = hash[:name]          || "Unnamed"
+      @icon_position = hash[:icon_position] || -1   # -1 means "no icon"
     end
 
     # @return [String] the translated name of this body shape
@@ -33,85 +32,85 @@ end
 #===============================================================================
 
 GameData::BodyShape.register({
-  :id        => :Head,
-  :id_number => 1,
-  :name      => _INTL("Head")
+  :id            => :Head,
+  :name          => _INTL("Head"),
+  :icon_position => 0
 })
 
 GameData::BodyShape.register({
-  :id        => :Serpentine,
-  :id_number => 2,
-  :name      => _INTL("Serpentine")
+  :id            => :Serpentine,
+  :name          => _INTL("Serpentine"),
+  :icon_position => 1
 })
 
 GameData::BodyShape.register({
-  :id        => :Finned,
-  :id_number => 3,
-  :name      => _INTL("Finned")
+  :id            => :Finned,
+  :name          => _INTL("Finned"),
+  :icon_position => 2
 })
 
 GameData::BodyShape.register({
-  :id        => :HeadArms,
-  :id_number => 4,
-  :name      => _INTL("Head and arms")
+  :id            => :HeadArms,
+  :name          => _INTL("Head and arms"),
+  :icon_position => 3
 })
 
 GameData::BodyShape.register({
-  :id        => :HeadBase,
-  :id_number => 5,
-  :name      => _INTL("Head and base")
+  :id            => :HeadBase,
+  :name          => _INTL("Head and base"),
+  :icon_position => 4
 })
 
 GameData::BodyShape.register({
-  :id        => :BipedalTail,
-  :id_number => 6,
-  :name      => _INTL("Bipedal with tail")
+  :id            => :BipedalTail,
+  :name          => _INTL("Bipedal with tail"),
+  :icon_position => 5
 })
 
 GameData::BodyShape.register({
-  :id        => :HeadLegs,
-  :id_number => 7,
-  :name      => _INTL("Head and legs")
+  :id            => :HeadLegs,
+  :name          => _INTL("Head and legs"),
+  :icon_position => 6
 })
 
 GameData::BodyShape.register({
-  :id        => :Quadruped,
-  :id_number => 8,
-  :name      => _INTL("Quadruped")
+  :id            => :Quadruped,
+  :name          => _INTL("Quadruped"),
+  :icon_position => 7
 })
 
 GameData::BodyShape.register({
-  :id        => :Winged,
-  :id_number => 9,
-  :name      => _INTL("Winged")
+  :id            => :Winged,
+  :name          => _INTL("Winged"),
+  :icon_position => 8
 })
 
 GameData::BodyShape.register({
-  :id        => :Multiped,
-  :id_number => 10,
-  :name      => _INTL("Multiped")
+  :id            => :Multiped,
+  :name          => _INTL("Multiped"),
+  :icon_position => 9
 })
 
 GameData::BodyShape.register({
-  :id        => :MultiBody,
-  :id_number => 11,
-  :name      => _INTL("Multi Body")
+  :id            => :MultiBody,
+  :name          => _INTL("Multi Body"),
+  :icon_position => 10
 })
 
 GameData::BodyShape.register({
-  :id        => :Bipedal,
-  :id_number => 12,
-  :name      => _INTL("Bipedal")
+  :id            => :Bipedal,
+  :name          => _INTL("Bipedal"),
+  :icon_position => 11
 })
 
 GameData::BodyShape.register({
-  :id        => :MultiWinged,
-  :id_number => 13,
-  :name      => _INTL("Multi Winged")
+  :id            => :MultiWinged,
+  :name          => _INTL("Multi Winged"),
+  :icon_position => 12
 })
 
 GameData::BodyShape.register({
-  :id        => :Insectoid,
-  :id_number => 14,
-  :name      => _INTL("Insectoid")
+  :id            => :Insectoid,
+  :name          => _INTL("Insectoid"),
+  :icon_position => 13
 })