Waged war against TODO comments in the AI, some refactoring of AI

This commit is contained in:
Maruno17
2023-05-07 23:12:39 +01:00
parent b7a40d0344
commit 7a8754c425
17 changed files with 702 additions and 830 deletions

View File

@@ -1,71 +1,9 @@
#===============================================================================
#
#===============================================================================
class Battle::AI
def pbAIRandom(x); return rand(x); end
def pbStdDev(choices)
sum = 0
n = 0
choices.each do |c|
sum += c[1]
n += 1
end
return 0 if n < 2
mean = sum.to_f / n
varianceTimesN = 0
choices.each do |c|
next if c[1] <= 0
deviation = c[1].to_f - mean
varianceTimesN += deviation * deviation
end
# Using population standard deviation
# [(n-1) makes it a sample std dev, would be 0 with only 1 sample]
return Math.sqrt(varianceTimesN / n)
end
#-----------------------------------------------------------------------------
# Move's type effectiveness. For switching. Determines the effectiveness of a
# potential switch-in against an opposing battler.
# TODO: Unused.
def pbCalcTypeModPokemon(pkmn, target_battler)
ret = Effectiveness::NORMAL_EFFECTIVE_MULTIPLIER
pkmn.types.each do |thisType|
ret *= Effectiveness.calculate(thisType, *target_battler.types)
end
return ret
end
# Assumes that pkmn's ability is not negated by a global effect (e.g.
# Neutralizing Gas).
# pkmn is either a Battle::AI::AIBattler or a Pokemon. move is a Battle::Move.
def pokemon_can_absorb_move?(pkmn, move, move_type)
return false if pkmn.is_a?(Battle::AI::AIBattler) && !pkmn.ability_active?
# Check pkmn's ability
# Anything with a Battle::AbilityEffects::MoveImmunity handler
# TODO: Are there any other absorbing effects? Held item?
case pkmn.ability_id
when :BULLETPROOF
return move.bombMove?
when :FLASHFIRE
return move_type == :FIRE
when :LIGHTNINGROD, :MOTORDRIVE, :VOLTABSORB
return move_type == :ELECTRIC
when :SAPSIPPER
return move_type == :GRASS
when :SOUNDPROOF
return move.soundMove?
when :STORMDRAIN, :WATERABSORB, :DRYSKIN
return move_type == :WATER
when :TELEPATHY
# NOTE: The move is being used by a foe of pkmn.
return false
when :WONDERGUARD
types = pkmn.types
types = pkmn.pbTypes(true) if pkmn.is_a?(Battle::AI::AIBattler)
return Effectiveness.super_effective_type?(move_type, *types)
end
return false
end
#-----------------------------------------------------------------------------
def each_battler
@@ -95,4 +33,439 @@ class Battle::AI
yield battler, i if i != index && i.even? == index.even?
end
end
#-----------------------------------------------------------------------------
# Assumes that pkmn's ability is not negated by a global effect (e.g.
# Neutralizing Gas).
# pkmn is either a Battle::AI::AIBattler or a Pokemon. move is a Battle::Move.
def pokemon_can_absorb_move?(pkmn, move, move_type)
return false if pkmn.is_a?(Battle::AI::AIBattler) && !pkmn.ability_active?
# Check pkmn's ability
# Anything with a Battle::AbilityEffects::MoveImmunity handler
case pkmn.ability_id
when :BULLETPROOF
return move.bombMove?
when :FLASHFIRE
return move_type == :FIRE
when :LIGHTNINGROD, :MOTORDRIVE, :VOLTABSORB
return move_type == :ELECTRIC
when :SAPSIPPER
return move_type == :GRASS
when :SOUNDPROOF
return move.soundMove?
when :STORMDRAIN, :WATERABSORB, :DRYSKIN
return move_type == :WATER
when :TELEPATHY
# NOTE: The move is being used by a foe of pkmn.
return false
when :WONDERGUARD
types = pkmn.types
types = pkmn.pbTypes(true) if pkmn.is_a?(Battle::AI::AIBattler)
return Effectiveness.super_effective_type?(move_type, *types)
end
return false
end
# Used by Toxic Spikes.
def pokemon_can_be_poisoned?(pkmn)
# Check pkmn's immunity to being poisoned
return false if @battle.field.terrain == :Misty
return false if pkmn.hasType?(:POISON)
return false if pkmn.hasType?(:STEEL)
return false if pkmn.hasAbility?(:IMMUNITY)
return false if pkmn.hasAbility?(:PASTELVEIL)
return false if pkmn.hasAbility?(:FLOWERVEIL) && pkmn.hasType?(:GRASS)
return false if pkmn.hasAbility?(:LEAFGUARD) && [:Sun, :HarshSun].include?(@battle.pbWeather)
return false if pkmn.hasAbility?(:COMATOSE) && pkmn.isSpecies?(:KOMALA)
return false if pkmn.hasAbility?(:SHIELDSDOWN) && pkmn.isSpecies?(:MINIOR) && pkmn.form < 7
return true
end
def pokemon_airborne?(pkmn)
return false if pkmn.hasItem?(:IRONBALL)
return false if @battle.field.effects[PBEffects::Gravity] > 0
return true if pkmn.hasType?(:FLYING)
return true if pkmn.hasAbility?(:LEVITATE)
return true if pkmn.hasItem?(:AIRBALLOON)
return false
end
#-----------------------------------------------------------------------------
# These values are taken from the Complete-Fire-Red-Upgrade decomp here:
# https://github.com/Skeli789/Complete-Fire-Red-Upgrade/blob/f7f35becbd111c7e936b126f6328fc52d9af68c8/src/ability_battle_effects.c#L41
BASE_ABILITY_RATINGS = {
10 => [:DELTASTREAM, :DESOLATELAND, :HUGEPOWER, :MOODY, :PARENTALBOND,
:POWERCONSTRUCT, :PRIMORDIALSEA, :PUREPOWER, :SHADOWTAG,
:STANCECHANGE, :WONDERGUARD],
9 => [:ARENATRAP, :DRIZZLE, :DROUGHT, :IMPOSTER, :MAGICBOUNCE, :MAGICGUARD,
:MAGNETPULL, :SANDSTREAM, :SPEEDBOOST],
8 => [:ADAPTABILITY, :AERILATE, :CONTRARY, :DISGUISE, :DRAGONSMAW,
:ELECTRICSURGE, :GALVANIZE, :GRASSYSURGE, :ILLUSION, :LIBERO,
:MISTYSURGE, :MULTISCALE, :MULTITYPE, :NOGUARD, :POISONHEAL,
:PIXILATE, :PRANKSTER, :PROTEAN, :PSYCHICSURGE, :REFRIGERATE,
:REGENERATOR, :RKSSYSTEM, :SERENEGRACE, :SHADOWSHIELD, :SHEERFORCE,
:SIMPLE, :SNOWWARNING, :TECHNICIAN, :TRANSISTOR, :WATERBUBBLE],
7 => [:BEASTBOOST, :BULLETPROOF, :COMPOUNDEYES, :DOWNLOAD, :FURCOAT,
:HUSTLE, :ICESCALES, :INTIMIDATE, :LEVITATE, :LIGHTNINGROD,
:MEGALAUNCHER, :MOLDBREAKER, :MOXIE, :NATURALCURE, :SAPSIPPER,
:SHEDSKIN, :SKILLLINK, :SOULHEART, :STORMDRAIN, :TERAVOLT, :THICKFAT,
:TINTEDLENS, :TOUGHCLAWS, :TRIAGE, :TURBOBLAZE, :UNBURDEN,
:VOLTABSORB, :WATERABSORB],
6 => [:BATTLEBOND, :CHLOROPHYLL, :COMATOSE, :DARKAURA, :DRYSKIN,
:FAIRYAURA, :FILTER, :FLASHFIRE, :FORECAST, :GALEWINGS, :GUTS,
:INFILTRATOR, :IRONBARBS, :IRONFIST, :MIRRORARMOR, :MOTORDRIVE,
:NEUROFORCE, :PRISMARMOR, :QUEENLYMAJESTY, :RECKLESS, :ROUGHSKIN,
:SANDRUSH, :SCHOOLING, :SCRAPPY, :SHIELDSDOWN, :SOLIDROCK, :STAKEOUT,
:STAMINA, :STEELWORKER, :STRONGJAW, :STURDY, :SWIFTSWIM, :TOXICBOOST,
:TRACE, :UNAWARE, :VICTORYSTAR],
5 => [:AFTERMATH, :AIRLOCK, :ANALYTIC, :BERSERK, :BLAZE, :CLOUDNINE,
:COMPETITIVE, :CORROSION, :DANCER, :DAZZLING, :DEFIANT, :FLAREBOOST,
:FLUFFY, :GOOEY, :HARVEST, :HEATPROOF, :INNARDSOUT, :LIQUIDVOICE,
:MARVELSCALE, :MUMMY, :NEUTRALIZINGGAS, :OVERCOAT, :OVERGROW,
:PRESSURE, :QUICKFEET, :ROCKHEAD, :SANDSPIT, :SHIELDDUST, :SLUSHRUSH,
:SWARM, :TANGLINGHAIR, :TORRENT],
4 => [:ANGERPOINT, :BADDREAMS, :CHEEKPOUCH, :CLEARBODY, :CURSEDBODY,
:EARLYBIRD, :EFFECTSPORE, :FLAMEBODY, :FLOWERGIFT, :FULLMETALBODY,
:GORILLATACTICS, :HYDRATION, :ICEFACE, :IMMUNITY, :INSOMNIA,
:JUSTIFIED, :MERCILESS, :PASTELVEIL, :POISONPOINT, :POISONTOUCH,
:RIPEN, :SANDFORCE, :SOUNDPROOF, :STATIC, :SURGESURFER, :SWEETVEIL,
:SYNCHRONIZE, :VITALSPIRIT, :WATERCOMPACTION, :WATERVEIL,
:WHITESMOKE, :WONDERSKIN],
3 => [:AROMAVEIL, :AURABREAK, :COTTONDOWN, :DAUNTLESSSHIELD,
:EMERGENCYEXIT, :GLUTTONY, :GULPMISSLE, :HYPERCUTTER, :ICEBODY,
:INTREPIDSWORD, :LIMBER, :LIQUIDOOZE, :LONGREACH, :MAGICIAN,
:OWNTEMPO, :PICKPOCKET, :RAINDISH, :RATTLED, :SANDVEIL,
:SCREENCLEANER, :SNIPER, :SNOWCLOAK, :SOLARPOWER, :STEAMENGINE,
:STICKYHOLD, :SUPERLUCK, :UNNERVE, :WIMPOUT],
2 => [:BATTLEARMOR, :COLORCHANGE, :CUTECHARM, :DAMP, :GRASSPELT,
:HUNGERSWITCH, :INNERFOCUS, :LEAFGUARD, :LIGHTMETAL, :MIMICRY,
:OBLIVIOUS, :POWERSPOT, :PROPELLORTAIL, :PUNKROCK, :SHELLARMOR,
:STALWART, :STEADFAST, :STEELYSPIRIT, :SUCTIONCUPS, :TANGLEDFEET,
:WANDERINGSPIRIT, :WEAKARMOR],
1 => [:BIGPECKS, :KEENEYE, :MAGMAARMOR, :PICKUP, :RIVALRY, :STENCH],
0 => [:ANTICIPATION, :ASONECHILLINGNEIGH, :ASONEGRIMNEIGH, :BALLFETCH,
:BATTERY, :CHILLINGNEIGH, :CURIOUSMEDICINE, :FLOWERVEIL, :FOREWARN,
:FRIENDGUARD, :FRISK, :GRIMNEIGH, :HEALER, :HONEYGATHER, :ILLUMINATE,
:MINUS, :PLUS, :POWEROFALCHEMY, :QUICKDRAW, :RECEIVER, :RUNAWAY,
:SYMBIOSIS, :TELEPATHY, :UNSEENFIST],
-1 => [:DEFEATIST, :HEAVYMETAL, :KLUTZ, :NORMALIZE, :PERISHBODY, :STALL,
:ZENMODE],
-2 => [:SLOWSTART, :TRUANT]
}
#-----------------------------------------------------------------------------
# TODO: Add more items.
BASE_ITEM_RATINGS = {
4 => [:CHOICEBAND, :CHOICESCARF, :CHOICESPECS, :DEEPSEATOOTH, :LEFTOVERS,
:LIGHTBALL, :THICKCLUB],
3 => [:ADAMANTORB, :GRISEOUSORB, :LIFEORB, :LUSTROUSORB, :SOULDEW],
2 => [:BLACKBELT, :BLACKGLASSES, :CHARCOAL, :DRAGONFANG, :HARDSTONE,
:MAGNET, :METALCOAT, :MIRACLESEED, :MYSTICWATER, :NEVERMELTICE,
:POISONBARB, :SHARPBEAK, :SILKSCARF, :SILVERPOWDER, :SOFTSAND,
:SPELLTAG, :TWISTEDSPOON,
:DRACOPLATE, :DREADPLATE, :EARTHPLATE, :FISTPLATE, :FLAMEPLATE,
:ICICLEPLATE, :INSECTPLATE, :IRONPLATE, :MEADOWPLATE, :MINDPLATE,
:PIXIEPLATE, :SKYPLATE, :SPLASHPLATE, :SPOOKYPLATE, :STONEPLATE,
:TOXICPLATE, :ZAPPLATE,
:ODDINCENSE, :ROCKINCENSE, :ROSEINCENSE, :SEAINCENSE, :WAVEINCENSE,
:MUSCLEBAND, :WISEGLASSES],
1 => [:METRONOME],
-2 => [:LAGGINGTAIL, :STICKYBARB],
-4 => [:BLACKSLUDGE, :FLAMEORB, :IRONBALL, :TOXICORB]
}
end
#===============================================================================
#
#===============================================================================
Battle::AI::Handlers::AbilityRanking.add(:BLAZE,
proc { |ability, score, battler, ai|
next score if battler.has_damaging_move_of_type?(:FIRE)
next 0
}
)
Battle::AI::Handlers::AbilityRanking.add(:CUTECHARM,
proc { |ability, score, battler, ai|
next 0 if battler.gender == 2
next score
}
)
Battle::AI::Handlers::AbilityRanking.copy(:CUTECHARM, :RIVALRY)
Battle::AI::Handlers::AbilityRanking.add(:FRIENDGUARD,
proc { |ability, score, battler, ai|
has_ally = false
ai.each_ally(battler.side) { |b, i| has_ally = true }
next score if has_ally
next 0
}
)
Battle::AI::Handlers::AbilityRanking.copy(:FRIENDGUARD, :HEALER, :SYMBOISIS, :TELEPATHY)
Battle::AI::Handlers::AbilityRanking.add(:GALEWINGS,
proc { |ability, score, battler, ai|
next score if battler.check_for_move { |m| m.type == :FLYING }
next 0
}
)
Battle::AI::Handlers::AbilityRanking.add(:HUGEPOWER,
proc { |ability, score, battler, ai|
next score if ai.stat_raise_worthwhile?(battler, :ATTACK, true)
next 0
}
)
Battle::AI::Handlers::AbilityRanking.copy(:HUGEPOWER, :PUREPOWER)
Battle::AI::Handlers::AbilityRanking.add(:IRONFIST,
proc { |ability, score, battler, ai|
next score if battler.check_for_move { |m| m.punchingMove? }
next 0
}
)
Battle::AI::Handlers::AbilityRanking.add(:LIQUIDVOICE,
proc { |ability, score, battler, ai|
next score if battler.check_for_move { |m| m.soundMove? }
next 0
}
)
Battle::AI::Handlers::AbilityRanking.add(:MEGALAUNCHER,
proc { |ability, score, battler, ai|
next score if battler.check_for_move { |m| m.pulseMove? }
next 0
}
)
Battle::AI::Handlers::AbilityRanking.add(:OVERGROW,
proc { |ability, score, battler, ai|
next score if battler.has_damaging_move_of_type?(:GRASS)
next 0
}
)
Battle::AI::Handlers::AbilityRanking.add(:PRANKSTER,
proc { |ability, score, battler, ai|
next score if battler.check_for_move { |m| m.statusMove? }
next 0
}
)
Battle::AI::Handlers::AbilityRanking.add(:PUNKROCK,
proc { |ability, score, battler, ai|
next score if battler.check_for_move { |m| m.damagingMove? && m.soundMove? }
next 1
}
)
Battle::AI::Handlers::AbilityRanking.add(:RECKLESS,
proc { |ability, score, battler, ai|
next score if battler.check_for_move { |m| m.recoilMove? }
next 0
}
)
Battle::AI::Handlers::AbilityRanking.add(:ROCKHEAD,
proc { |ability, score, battler, ai|
next score if battler.check_for_move { |m| m.recoilMove? && !m.is_a?(Battle::Move::CrashDamageIfFailsUnusableInGravity) }
next 0
}
)
Battle::AI::Handlers::AbilityRanking.add(:RUNAWAY,
proc { |ability, score, battler, ai|
next 0 if battler.wild?
next score
}
)
Battle::AI::Handlers::AbilityRanking.add(:SANDFORCE,
proc { |ability, score, battler, ai|
next score if battler.has_damaging_move_of_type?(:GROUND, :ROCK, :STEEL)
next 2
}
)
Battle::AI::Handlers::AbilityRanking.add(:SKILLLINK,
proc { |ability, score, battler, ai|
next score if battler.check_for_move { |m| m.is_a?(Battle::Move::HitTwoToFiveTimes) }
next 0
}
)
Battle::AI::Handlers::AbilityRanking.add(:STEELWORKER,
proc { |ability, score, battler, ai|
next score if battler.has_damaging_move_of_type?(:STEEL)
next 0
}
)
Battle::AI::Handlers::AbilityRanking.add(:SWARM,
proc { |ability, score, battler, ai|
next score if battler.has_damaging_move_of_type?(:BUG)
next 0
}
)
Battle::AI::Handlers::AbilityRanking.add(:TORRENT,
proc { |ability, score, battler, ai|
next score if battler.has_damaging_move_of_type?(:WATER)
next 0
}
)
Battle::AI::Handlers::AbilityRanking.add(:TRIAGE,
proc { |ability, score, battler, ai|
next score if battler.check_for_move { |m| m.healingMove? }
next 0
}
)
#===============================================================================
#
#===============================================================================
Battle::AI::Handlers::ItemRanking.add(:ADAMANTORB,
proc { |item, score, battler, ai|
next score if battler.battler.isSpecies?(:DIALGA) &&
battler.has_damaging_move_of_type?(:DRAGON, :STEEL)
next 0
}
)
Battle::AI::Handlers::ItemRanking.add(:BLACKSLUDGE,
proc { |item, score, battler, ai|
next 4 if battler.has_type?(:POISON)
next score
}
)
Battle::AI::Handlers::ItemRanking.add(:CHOICEBAND,
proc { |item, score, battler, ai|
next score if battler.check_for_move { |m| m.physicalMove?(m.type) }
next 0
}
)
Battle::AI::Handlers::ItemRanking.copy(:CHOICEBAND, :MUSCLEBAND)
Battle::AI::Handlers::ItemRanking.add(:CHOICESPECS,
proc { |item, score, battler, ai|
next score if battler.check_for_move { |m| m.specialMove?(m.type) }
next 0
}
)
Battle::AI::Handlers::ItemRanking.copy(:CHOICESPECS, :WISEGLASSES)
Battle::AI::Handlers::ItemRanking.add(:DEEPSEATOOTH,
proc { |item, score, battler, ai|
next score if battler.battler.isSpecies?(:CLAMPERL) &&
battler.check_for_move { |m| m.specialMove?(m.type) }
next 0
}
)
Battle::AI::Handlers::ItemRanking.add(:GRISEOUSORB,
proc { |item, score, battler, ai|
next score if battler.battler.isSpecies?(:GIRATINA) &&
battler.has_damaging_move_of_type?(:DRAGON, :GHOST)
next 0
}
)
Battle::AI::Handlers::ItemRanking.add(:IRONBALL,
proc { |item, score, battler, ai|
next 0 if battler.has_move_with_function?("ThrowUserItemAtTarget")
next score
}
)
Battle::AI::Handlers::ItemRanking.add(:LIGHTBALL,
proc { |item, score, battler, ai|
next score if battler.battler.isSpecies?(:PIKACHU) &&
battler.check_for_move { |m| m.damagingMove? }
next 0
}
)
Battle::AI::Handlers::ItemRanking.add(:LUSTROUSORB,
proc { |item, score, battler, ai|
next score if battler.battler.isSpecies?(:PALKIA) &&
battler.has_damaging_move_of_type?(:DRAGON, :WATER)
next 0
}
)
Battle::AI::Handlers::ItemRanking.add(:SOULDEW,
proc { |item, score, battler, ai|
next 0 if !battler.battler.isSpecies?(:LATIAS) && !battler.battler.isSpecies?(:LATIOS)
if Settings::SOUL_DEW_POWERS_UP_TYPES
next 0 if !battler.has_damaging_move_of_type?(:PSYCHIC, :DRAGON)
elsif !battler.check_for_move { |m| m.specialMove?(m.type) }
next 1 # Also boosts SpDef
end
next score
}
)
Battle::AI::Handlers::ItemRanking.add(:THICKCLUB,
proc { |item, score, battler, ai|
next score if (battler.battler.isSpecies?(:CUBONE) || battler.battler.isSpecies?(:MAROWAK)) &&
battler.check_for_move { |m| m.physicalMove?(m.type) }
next 0
}
)
Battle::AI::Handlers::ItemRanking.addIf(:type_boosting_items,
proc { |item|
next [:BLACKBELT, :BLACKGLASSES, :CHARCOAL, :DRAGONFANG, :HARDSTONE,
:MAGNET, :METALCOAT, :MIRACLESEED, :MYSTICWATER, :NEVERMELTICE,
:POISONBARB, :SHARPBEAK, :SILKSCARF, :SILVERPOWDER, :SOFTSAND,
:SPELLTAG, :TWISTEDSPOON,
:DRACOPLATE, :DREADPLATE, :EARTHPLATE, :FISTPLATE, :FLAMEPLATE,
:ICICLEPLATE, :INSECTPLATE, :IRONPLATE, :MEADOWPLATE, :MINDPLATE,
:PIXIEPLATE, :SKYPLATE, :SPLASHPLATE, :SPOOKYPLATE, :STONEPLATE,
:TOXICPLATE, :ZAPPLATE,
:ODDINCENSE, :ROCKINCENSE, :ROSEINCENSE, :SEAINCENSE, :WAVEINCENSE].include?(item)
},
proc { |item, score, battler, ai|
boosters = {
:BUG => [:SILVERPOWDER, :INSECTPLATE],
:DARK => [:BLACKGLASSES, :DREADPLATE],
:DRAGON => [:DRAGONFANG, :DRACOPLATE],
:ELECTRIC => [:MAGNET, :ZAPPLATE],
:FAIRY => [:PIXIEPLATE],
:FIGHTING => [:BLACKBELT, :FISTPLATE],
:FIRE => [:CHARCOAL, :FLAMEPLATE],
:FLYING => [:SHARPBEAK, :SKYPLATE],
:GHOST => [:SPELLTAG, :SPOOKYPLATE],
:GRASS => [:MIRACLESEED, :MEADOWPLATE, :ROSEINCENSE],
:GROUND => [:SOFTSAND, :EARTHPLATE],
:ICE => [:NEVERMELTICE, :ICICLEPLATE],
:NORMAL => [:SILKSCARF],
:POISON => [:POISONBARB, :TOXICPLATE],
:PSYCHIC => [:TWISTEDSPOON, :MINDPLATE, :ODDINCENSE],
:ROCK => [:HARDSTONE, :STONEPLATE, :ROCKINCENSE],
:STEEL => [:METALCOAT, :IRONPLATE],
:WATER => [:MYSTICWATER, :SPLASHPLATE, :SEAINCENSE, :WAVEINCENSE],
}
boosted_type = nil
boosters.each_pair do |type, items|
next if !items.include?(item)
boosted_type = type
break
end
next score if boosted_type && battler.has_damaging_move_of_type?(boosted_type)
next 0
}
)