From 8bb70a226e5f89447129b349de302f1b785c3a23 Mon Sep 17 00:00:00 2001 From: Maruno17 Date: Sun, 22 Aug 2021 23:18:34 +0100 Subject: [PATCH] Tidied up semicolon use, refactored random dungeon generation code, fixed visual bug in Day Care debug screen --- .../001_Technical/005_PluginManager.rb | 12 +- .../002_Save data/002_SaveData_Value.rb | 2 +- .../002_Save data/003_SaveData_Conversion.rb | 2 +- .../002_Save data/004_Game_SaveValues.rb | 4 +- .../004_Game classes/007_Game_Character.rb | 6 +- .../004_Game classes/009_Game_Player.rb | 11 +- Data/Scripts/005_Sprites/011_PictureEx.rb | 29 +- .../006_Map renderer/002_CustomTilemap.rb | 12 +- .../002_MessageConfig.rb | 2 +- .../007_Objects and windows/003_Window.rb | 14 +- .../004_SpriteWindow.rb | 24 +- .../007_SpriteWrapper.rb | 4 +- .../007_Objects and windows/009_Planes.rb | 10 +- .../007_Objects and windows/010_DrawText.rb | 13 +- Data/Scripts/008_Audio/002_Audio_Play.rb | 14 +- .../001_Battler/004_Battler_Statuses.rb | 3 +- .../008_Battler_UseMove_Targeting.rb | 9 +- .../009_Battler_UseMove_SuccessChecks.rb | 3 +- Data/Scripts/011_Battle/002_BattleHandlers.rb | 6 +- .../011_Battle/002_Move/002_Move_Usage.rb | 6 +- .../002_Move/004_Move_Effects_Generic.rb | 21 +- .../002_Move/005_Move_Effects_000-07F.rb | 18 +- .../002_Move/006_Move_Effects_080-0FF.rb | 72 +- .../002_Move/007_Move_Effects_100-17F.rb | 4 +- .../003_Battle/001_PokeBattle_BattleCommon.rb | 15 +- .../003_Battle/003_Battle_StartAndEnd.rb | 9 +- .../003_BattleHandlers_Abilities.rb | 4 +- Data/Scripts/011_Battle/004_AI/004_AI_Move.rb | 12 +- .../004_AI/005_AI_Move_EffectScores.rb | 21 +- .../005_BallHandlers_PokeBallEffects.rb | 30 +- .../005_Battle scene/009_Scene_Animations.rb | 25 +- .../001_PokeBattle_AnimationPlayer.rb | 2 +- .../005_PokeBattle_BattleArena.rb | 12 +- .../009_PokeBattle_Clauses.rb | 6 +- .../001_Overworld_BattleStarting.rb | 9 +- .../002_Overworld_BattleIntroAnim.rb | 6 +- .../012_Overworld/004_Overworld_FieldMoves.rb | 11 +- .../008_Overworld_RandomDungeons.rb | 1146 +++++++++-------- Data/Scripts/013_Items/002_Item_Effects.rb | 3 +- .../001_Pokemon-related/001_FormHandlers.rb | 9 +- .../003_Pokemon_Sprites.rb | 8 +- .../001_Pokemon-related/004_PokemonStorage.rb | 3 +- Data/Scripts/014_Pokemon/001_Pokemon.rb | 2 +- .../014_Pokemon/002_Pokemon_MegaEvolution.rb | 6 +- .../005_Player_Pokedex.rb | 6 +- Data/Scripts/016_UI/003_UI_Pokedex_Main.rb | 262 ++-- Data/Scripts/016_UI/004_UI_Pokedex_Entry.rb | 3 +- Data/Scripts/016_UI/005_UI_Party.rb | 34 +- Data/Scripts/016_UI/006_UI_Summary.rb | 42 +- Data/Scripts/016_UI/007_UI_Bag.rb | 6 +- Data/Scripts/016_UI/016_UI_ReadyMenu.rb | 6 +- Data/Scripts/016_UI/017_UI_PokemonStorage.rb | 29 +- Data/Scripts/016_UI/022_UI_PurifyChamber.rb | 8 +- Data/Scripts/016_UI/023_UI_MysteryGift.rb | 11 +- .../017_Minigames/002_Minigame_TripleTriad.rb | 15 +- .../017_Minigames/006_Minigame_Mining.rb | 21 +- .../017_Minigames/007_Minigame_TilePuzzles.rb | 27 +- .../001_Battle Frontier/002_Challenge_Data.rb | 4 +- .../004_ChallengeGenerator_BattleSim.rb | 3 +- .../001_Editor screens/001_EditorScreens.rb | 6 +- .../005_AnimEditor_Functions.rb | 8 +- .../003_Debug_MenuExtraCode.rb | 17 +- Data/Scripts/021_Compiler/001_Compiler.rb | 3 +- .../004_Compiler_MapsAndEvents.rb | 61 +- 64 files changed, 1286 insertions(+), 926 deletions(-) diff --git a/Data/Scripts/001_Technical/005_PluginManager.rb b/Data/Scripts/001_Technical/005_PluginManager.rb index 1f47988bd..7c7e98009 100644 --- a/Data/Scripts/001_Technical/005_PluginManager.rb +++ b/Data/Scripts/001_Technical/005_PluginManager.rb @@ -409,11 +409,15 @@ module PluginManager #----------------------------------------------------------------------------- def self.compare_versions(v1, v2) d1 = v1.split("") - d1.insert(0, "0") if d1[0] == "." # Turn ".123" into "0.123" - while d1[-1] == "."; d1 = d1[0..-2]; end # Turn "123." into "123" + d1.insert(0, "0") if d1[0] == "." # Turn ".123" into "0.123" + while d1[-1] == "." # Turn "123." into "123" + d1 = d1[0..-2] + end d2 = v2.split("") - d2.insert(0, "0") if d2[0] == "." # Turn ".123" into "0.123" - while d2[-1] == "."; d2 = d2[0..-2]; end # Turn "123." into "123" + d2.insert(0, "0") if d2[0] == "." # Turn ".123" into "0.123" + while d2[-1] == "." # Turn "123." into "123" + d2 = d2[0..-2] + end for i in 0...[d1.size, d2.size].max # Compare each digit in turn c1 = d1[i] c2 = d2[i] diff --git a/Data/Scripts/002_Save data/002_SaveData_Value.rb b/Data/Scripts/002_Save data/002_SaveData_Value.rb index 7e5bdf9da..1ba2feb11 100644 --- a/Data/Scripts/002_Save data/002_SaveData_Value.rb +++ b/Data/Scripts/002_Save data/002_SaveData_Value.rb @@ -181,7 +181,7 @@ module SaveData # new_game_value { Bar.new } # end # @param id [Symbol] value id - # @yieldself [Value] + # @yield the block of code to be saved as a Value def self.register(id, &block) validate id => Symbol unless block_given? diff --git a/Data/Scripts/002_Save data/003_SaveData_Conversion.rb b/Data/Scripts/002_Save data/003_SaveData_Conversion.rb index c6e0175a7..1ab5f5b86 100644 --- a/Data/Scripts/002_Save data/003_SaveData_Conversion.rb +++ b/Data/Scripts/002_Save data/003_SaveData_Conversion.rb @@ -152,7 +152,7 @@ module SaveData # save_data[:new_value] = Foo.new # end # end - # @yield self [Conversion] + # @yield the block of code to be saved as a Conversion def self.register_conversion(id, &block) validate id => Symbol unless block_given? diff --git a/Data/Scripts/002_Save data/004_Game_SaveValues.rb b/Data/Scripts/002_Save data/004_Game_SaveValues.rb index 18d3ab07b..988c6f1e7 100644 --- a/Data/Scripts/002_Save data/004_Game_SaveValues.rb +++ b/Data/Scripts/002_Save data/004_Game_SaveValues.rb @@ -5,8 +5,8 @@ SaveData.register(:player) do save_value { $Trainer } load_value { |value| $Trainer = value } new_game_value { - trainer_type = nil # Get the first defined trainer type as a placeholder - GameData::TrainerType.each { |t| trainer_type = t.id; break } + # Get the first defined trainer type as a placeholder + trainer_type = GameData::TrainerType.keys.first Player.new("Unnamed", trainer_type) } from_old_format { |old_format| old_format[0] } diff --git a/Data/Scripts/004_Game classes/007_Game_Character.rb b/Data/Scripts/004_Game classes/007_Game_Character.rb index b7ddc4772..099ffc917 100644 --- a/Data/Scripts/004_Game classes/007_Game_Character.rb +++ b/Data/Scripts/004_Game classes/007_Game_Character.rb @@ -620,13 +620,15 @@ class Game_Character def move_random_range(xrange=-1,yrange=-1) dirs = [] # 0=down, 1=left, 2=right, 3=up if xrange<0 - dirs.push(1); dirs.push(2) + dirs.push(1) + dirs.push(2) elsif xrange>0 dirs.push(1) if @x > @original_x - xrange dirs.push(2) if @x < @original_x + xrange end if yrange<0 - dirs.push(0); dirs.push(3) + dirs.push(0) + dirs.push(3) elsif yrange>0 dirs.push(0) if @y < @original_y + yrange dirs.push(3) if @y > @original_y - yrange diff --git a/Data/Scripts/004_Game classes/009_Game_Player.rb b/Data/Scripts/004_Game classes/009_Game_Player.rb index aa0276784..c5593922d 100644 --- a/Data/Scripts/004_Game classes/009_Game_Player.rb +++ b/Data/Scripts/004_Game classes/009_Game_Player.rb @@ -400,10 +400,13 @@ end def pbUpdateVehicle meta = GameData::Metadata.get_player($Trainer.character_ID) if meta - charset = 1 # Regular graphic - if $PokemonGlobal.diving; charset = 5 # Diving graphic - elsif $PokemonGlobal.surfing; charset = 3 # Surfing graphic - elsif $PokemonGlobal.bicycle; charset = 2 # Bicycle graphic + charset = 1 # Regular graphic + if $PokemonGlobal.diving + charset = 5 # Diving graphic + elsif $PokemonGlobal.surfing + charset = 3 # Surfing graphic + elsif $PokemonGlobal.bicycle + charset = 2 # Bicycle graphic end newCharName = pbGetPlayerCharset(meta,charset) $game_player.character_name = newCharName if newCharName diff --git a/Data/Scripts/005_Sprites/011_PictureEx.rb b/Data/Scripts/005_Sprites/011_PictureEx.rb index 404924d91..08a590b4f 100644 --- a/Data/Scripts/005_Sprites/011_PictureEx.rb +++ b/Data/Scripts/005_Sprites/011_PictureEx.rb @@ -38,10 +38,14 @@ end def getCubicPoint2(src,t) - x0 = src[0]; y0 = src[1] - cx0 = src[2]; cy0 = src[3] - cx1 = src[4]; cy1 = src[5] - x1 = src[6]; y1 = src[7] + x0 = src[0] + y0 = src[1] + cx0 = src[2] + cy0 = src[3] + cx1 = src[4] + cy1 = src[5] + x1 = src[6] + y1 = src[7] x1 = cx1+(x1-cx1)*t x0 = x0+(cx0-x0)*t @@ -117,9 +121,12 @@ class PictureEx end def callback(cb) - if cb.is_a?(Proc); cb.call(self) - elsif cb.is_a?(Array); cb[0].method(cb[1]).call(self) - elsif cb.is_a?(Method); cb.call(self) + if cb.is_a?(Proc) + cb.call(self) + elsif cb.is_a?(Array) + cb[0].method(cb[1]).call(self) + elsif cb.is_a?(Method) + cb.call(self) end end @@ -163,7 +170,9 @@ class PictureEx # the angle another way too. def rotate(speed) @rotate_speed = speed*20.0/Graphics.frame_rate - while @rotate_speed<0; @rotate_speed += 360; end + while @rotate_speed<0 + @rotate_speed += 360 + end @rotate_speed %= 360 end @@ -440,7 +449,9 @@ class PictureEx if @rotate_speed != 0 @frameUpdates.push(Processes::Angle) if !@frameUpdates.include?(Processes::Angle) @angle += @rotate_speed - while @angle<0; @angle += 360; end + while @angle<0 + @angle += 360 + end @angle %= 360 end end diff --git a/Data/Scripts/006_Map renderer/002_CustomTilemap.rb b/Data/Scripts/006_Map renderer/002_CustomTilemap.rb index dd01df122..871833b6a 100644 --- a/Data/Scripts/006_Map renderer/002_CustomTilemap.rb +++ b/Data/Scripts/006_Map renderer/002_CustomTilemap.rb @@ -233,7 +233,8 @@ class CustomTilemap return if disposed? @help.dispose if @help @help = nil - i = 0; len = @autotileInfo.length + i = 0 + len = @autotileInfo.length while i=0 + i = half + while i>=0 break if realtext[i,1][/\s/]||isWaitChar(realtext[i,1]) # found a space leftSearch += 1 i -= 1 end # Search right for a space - i = half; while i=strength @@ -101,7 +102,8 @@ class PokeBattle_Battler priority = @battle.pbPriority(true) nearOnly = !target_data.can_choose_distant_target? # Spotlight (takes priority over Follow Me/Rage Powder/Lightning Rod/Storm Drain) - newTarget = nil; strength = 100 # Lower strength takes priority + newTarget = nil + strength = 100 # Lower strength takes priority priority.each do |b| next if b.fainted? || b.effects[PBEffects::SkyDrop]>=0 next if b.effects[PBEffects::Spotlight]==0 || @@ -118,7 +120,8 @@ class PokeBattle_Battler return targets end # Follow Me/Rage Powder (takes priority over Lightning Rod/Storm Drain) - newTarget = nil; strength = 100 # Lower strength takes priority + newTarget = nil + strength = 100 # Lower strength takes priority priority.each do |b| next if b.fainted? || b.effects[PBEffects::SkyDrop]>=0 next if b.effects[PBEffects::RagePowder] && !user.affectedByPowder? diff --git a/Data/Scripts/011_Battle/001_Battler/009_Battler_UseMove_SuccessChecks.rb b/Data/Scripts/011_Battle/001_Battler/009_Battler_UseMove_SuccessChecks.rb index e167ed180..44e03f2bd 100644 --- a/Data/Scripts/011_Battle/001_Battler/009_Battler_UseMove_SuccessChecks.rb +++ b/Data/Scripts/011_Battle/001_Battler/009_Battler_UseMove_SuccessChecks.rb @@ -506,7 +506,8 @@ class PokeBattle_Battler user.effects[PBEffects::LockOnPos]==target.index # Toxic return true if move.pbOverrideSuccessCheckPerHit(user,target) - miss = false; hitsInvul = false + miss = false + hitsInvul = false # No Guard hitsInvul = true if user.hasActiveAbility?(:NOGUARD) || target.hasActiveAbility?(:NOGUARD) diff --git a/Data/Scripts/011_Battle/002_BattleHandlers.rb b/Data/Scripts/011_Battle/002_BattleHandlers.rb index 778a3f486..0aa4fa477 100644 --- a/Data/Scripts/011_Battle/002_BattleHandlers.rb +++ b/Data/Scripts/011_Battle/002_BattleHandlers.rb @@ -493,8 +493,10 @@ def pbBattleConfusionBerry(battler,battle,item,forced,flavor,confuseMsg) return false if !forced && !battler.canConsumePinchBerry?(Settings::MECHANICS_GENERATION >= 7) itemName = GameData::Item.get(item).name fraction_to_heal = 8 # Gens 6 and lower - if Settings::MECHANICS_GENERATION == 7; fraction_to_heal = 2 - elsif Settings::MECHANICS_GENERATION >= 8; fraction_to_heal = 3 + if Settings::MECHANICS_GENERATION == 7 + fraction_to_heal = 2 + elsif Settings::MECHANICS_GENERATION >= 8 + fraction_to_heal = 3 end amt = battler.totalhp / fraction_to_heal ripening = false diff --git a/Data/Scripts/011_Battle/002_Move/002_Move_Usage.rb b/Data/Scripts/011_Battle/002_Move/002_Move_Usage.rb index b52a13838..43af99782 100644 --- a/Data/Scripts/011_Battle/002_Move/002_Move_Usage.rb +++ b/Data/Scripts/011_Battle/002_Move/002_Move_Usage.rb @@ -240,8 +240,10 @@ class PokeBattle_Move oldHP = b.hp+b.damageState.hpLost PBDebug.log("[Move damage] #{b.pbThis} lost #{b.damageState.hpLost} HP (#{oldHP}=>#{b.hp})") effectiveness = 0 - if Effectiveness.resistant?(b.damageState.typeMod); effectiveness = 1 - elsif Effectiveness.super_effective?(b.damageState.typeMod); effectiveness = 2 + if Effectiveness.resistant?(b.damageState.typeMod) + effectiveness = 1 + elsif Effectiveness.super_effective?(b.damageState.typeMod) + effectiveness = 2 end animArray.push([b,oldHP,effectiveness]) end diff --git a/Data/Scripts/011_Battle/002_Move/004_Move_Effects_Generic.rb b/Data/Scripts/011_Battle/002_Move/004_Move_Effects_Generic.rb index 19b90b916..a9f644367 100644 --- a/Data/Scripts/011_Battle/002_Move/004_Move_Effects_Generic.rb +++ b/Data/Scripts/011_Battle/002_Move/004_Move_Effects_Generic.rb @@ -492,8 +492,10 @@ class PokeBattle_TwoTurnMove < PokeBattle_Move end def pbEffectAgainstTarget(user,target) - if @damagingTurn; pbAttackingTurnEffect(user,target) - elsif @chargingTurn; pbChargingTurnEffect(user,target) + if @damagingTurn + pbAttackingTurnEffect(user,target) + elsif @chargingTurn + pbChargingTurnEffect(user,target) end end @@ -652,14 +654,20 @@ end #=============================================================================== class PokeBattle_PledgeMove < PokeBattle_Move def pbOnStartUse(user,targets) - @pledgeSetup = false; @pledgeCombo = false; @pledgeOtherUser = nil - @comboEffect = nil; @overrideType = nil; @overrideAnim = nil + @pledgeSetup = false + @pledgeCombo = false + @pledgeOtherUser = nil + @comboEffect = nil + @overrideType = nil + @overrideAnim = nil # Check whether this is the use of a combo move @combos.each do |i| next if i[0]!=user.effects[PBEffects::FirstPledge] @battle.pbDisplay(_INTL("The two moves have become one! It's a combined move!")) @pledgeCombo = true - @comboEffect = i[1]; @overrideType = i[2]; @overrideAnim = i[3] + @comboEffect = i[1] + @overrideType = i[2] + @overrideAnim = i[3] @overrideType = nil if !GameData::Type.exists?(@overrideType) break end @@ -706,7 +714,8 @@ class PokeBattle_PledgeMove < PokeBattle_Move def pbEffectAfterAllHits(user,target) return if !@pledgeCombo - msg = nil; animName = nil + msg = nil + animName = nil case @comboEffect when :SeaOfFire # Grass + Fire if user.pbOpposingSide.effects[PBEffects::SeaOfFire]==0 diff --git a/Data/Scripts/011_Battle/002_Move/005_Move_Effects_000-07F.rb b/Data/Scripts/011_Battle/002_Move/005_Move_Effects_000-07F.rb index 81543ff75..5a0f6d711 100644 --- a/Data/Scripts/011_Battle/002_Move/005_Move_Effects_000-07F.rb +++ b/Data/Scripts/011_Battle/002_Move/005_Move_Effects_000-07F.rb @@ -927,12 +927,14 @@ class PokeBattle_Move_035 < PokeBattle_Move failed = true for i in 0...@statUp.length/2 if user.pbCanRaiseStatStage?(@statUp[i*2],user,self) - failed = false; break + failed = false + break end end for i in 0...@statDown.length/2 if user.pbCanLowerStatStage?(@statDown[i*2],user,self) - failed = false; break + failed = false + break end end if failed @@ -1686,11 +1688,15 @@ end class PokeBattle_Move_05A < PokeBattle_Move def pbEffectAgainstTarget(user,target) newHP = (user.hp+target.hp)/2 - if user.hp>newHP; user.pbReduceHP(user.hp-newHP,false,false) - elsif user.hpnewHP + user.pbReduceHP(user.hp-newHP,false,false) + elsif user.hpnewHP; target.pbReduceHP(target.hp-newHP,false,false) - elsif target.hpnewHP + target.pbReduceHP(target.hp-newHP,false,false) + elsif target.hp