From d099d788f4fb96b3e2f9c478c3f2165355f43cbd Mon Sep 17 00:00:00 2001 From: chardub Date: Thu, 20 Feb 2025 17:09:56 -0500 Subject: [PATCH] Refactor: double hats --- Data/Scripts/052_AddOns/TRQuests.rb | 24 ++++++++++++++++-------- 1 file changed, 16 insertions(+), 8 deletions(-) diff --git a/Data/Scripts/052_AddOns/TRQuests.rb b/Data/Scripts/052_AddOns/TRQuests.rb index 11c7e742d..a9bef5431 100644 --- a/Data/Scripts/052_AddOns/TRQuests.rb +++ b/Data/Scripts/052_AddOns/TRQuests.rb @@ -5,15 +5,23 @@ def isWearingTeamRocketOutfit() end def isWearingFavoriteOutfit() - is_wearing_favorite_hat = $Trainer.hat == $Trainer.favorite_hat || !$Trainer.favorite_hat - is_wearing_favorite_clothes = $Trainer.clothes == $Trainer.favorite_clothes || !$Trainer.favorite_clothes - if $Trainer.favorite_hat && !$Trainer.favorite_clothes - return is_wearing_favorite_hat + favorites = { + hat: $Trainer.favorite_hat, + hat2: $Trainer.favorite_hat2, + clothes: $Trainer.favorite_clothes + } + favorites.select! { |item, favorite| !favorite.nil? } + return false if favorites.empty? + return favorites.all? do |item, favorite| + case item + when :hat + $Trainer.hat == favorite + when :hat2 + $Trainer.hat2 == favorite + when :clothes + $Trainer.clothes == favorite + end end - if $Trainer.favorite_clothes && !$Trainer.favorite_hat - return is_wearing_favorite_clothes - end - return is_wearing_favorite_clothes && is_wearing_favorite_hat end def obtainRocketOutfit()