Added decent spacing to all scripts thanks to Rubocop

Data/Scripts/016_UI/015_UI_Options.rb

@@ -50,7 +50,7 @@ class EnumOption
   attr_reader :values
   attr_reader :name
 
-  def initialize(name,options,getProc,setProc)
+  def initialize(name, options, getProc, setProc)
     @name    = name
     @values  = options
     @getProc = getProc
@@ -58,14 +58,14 @@ class EnumOption
   end
 
   def next(current)
-    index = current+1
-    index = @values.length-1 if index>@values.length-1
+    index = current + 1
+    index = @values.length - 1 if index > @values.length - 1
     return index
   end
 
   def prev(current)
-    index = current-1
-    index = 0 if index<0
+    index = current - 1
+    index = 0 if index < 0
     return index
   end
 end
@@ -78,7 +78,7 @@ class EnumOption2
   attr_reader :values
   attr_reader :name
 
-  def initialize(name,options,getProc,setProc)
+  def initialize(name, options, getProc, setProc)
     @name    = name
     @values  = options
     @getProc = getProc
@@ -86,14 +86,14 @@ class EnumOption2
   end
 
   def next(current)
-    index = current+1
-    index = @values.length-1 if index>@values.length-1
+    index = current + 1
+    index = @values.length - 1 if index > @values.length - 1
     return index
   end
 
   def prev(current)
-    index = current-1
-    index = 0 if index<0
+    index = current - 1
+    index = 0 if index < 0
     return index
   end
 end
@@ -107,7 +107,7 @@ class NumberOption
   attr_reader :optstart
   attr_reader :optend
 
-  def initialize(name,optstart,optend,getProc,setProc)
+  def initialize(name, optstart, optend, getProc, setProc)
     @name     = name
     @optstart = optstart
     @optend   = optend
@@ -116,17 +116,17 @@ class NumberOption
   end
 
   def next(current)
-    index = current+@optstart
+    index = current + @optstart
     index += 1
-    index = @optstart if index>@optend
-    return index-@optstart
+    index = @optstart if index > @optend
+    return index - @optstart
   end
 
   def prev(current)
-    index = current+@optstart
+    index = current + @optstart
     index -= 1
-    index = @optend if index<@optstart
-    return index-@optstart
+    index = @optend if index < @optstart
+    return index - @optstart
   end
 end
 
@@ -139,7 +139,7 @@ class SliderOption
   attr_reader :optstart
   attr_reader :optend
 
-  def initialize(name,optstart,optend,optinterval,getProc,setProc)
+  def initialize(name, optstart, optend, optinterval, getProc, setProc)
     @name        = name
     @optstart    = optstart
     @optend      = optend
@@ -149,17 +149,17 @@ class SliderOption
   end
 
   def next(current)
-    index = current+@optstart
+    index = current + @optstart
     index += @optinterval
-    index = @optend if index>@optend
-    return index-@optstart
+    index = @optend if index > @optend
+    return index - @optstart
   end
 
   def prev(current)
-    index = current+@optstart
+    index = current + @optstart
     index -= @optinterval
-    index = @optstart if index<@optstart
-    return index-@optstart
+    index = @optstart if index < @optstart
+    return index - @optstart
   end
 end
 
@@ -169,92 +169,92 @@ end
 class Window_PokemonOption < Window_DrawableCommand
   attr_reader :mustUpdateOptions
 
-  def initialize(options,x,y,width,height)
+  def initialize(options, x, y, width, height)
     @options = options
-    @nameBaseColor   = Color.new(24*8,15*8,0)
-    @nameShadowColor = Color.new(31*8,22*8,10*8)
-    @selBaseColor    = Color.new(31*8,6*8,3*8)
-    @selShadowColor  = Color.new(31*8,17*8,16*8)
+    @nameBaseColor   = Color.new(24 * 8, 15 * 8, 0)
+    @nameShadowColor = Color.new(31 * 8, 22 * 8, 10 * 8)
+    @selBaseColor    = Color.new(31 * 8, 6 * 8, 3 * 8)
+    @selShadowColor  = Color.new(31 * 8, 17 * 8, 16 * 8)
     @optvalues = []
     @mustUpdateOptions = false
     for i in 0...@options.length
       @optvalues[i] = 0
     end
-    super(x,y,width,height)
+    super(x, y, width, height)
   end
 
   def [](i)
     return @optvalues[i]
   end
 
-  def []=(i,value)
+  def []=(i, value)
     @optvalues[i] = value
     refresh
   end
 
-  def setValueNoRefresh(i,value)
+  def setValueNoRefresh(i, value)
     @optvalues[i] = value
   end
 
   def itemCount
-    return @options.length+1
+    return @options.length + 1
   end
 
-  def drawItem(index,_count,rect)
-    rect = drawCursor(index,rect)
-    optionname = (index==@options.length) ? _INTL("Cancel") : @options[index].name
-    optionwidth = rect.width*9/20
-    pbDrawShadowText(self.contents,rect.x,rect.y,optionwidth,rect.height,optionname,
-       @nameBaseColor,@nameShadowColor)
-    return if index==@options.length
+  def drawItem(index, _count, rect)
+    rect = drawCursor(index, rect)
+    optionname = (index == @options.length) ? _INTL("Cancel") : @options[index].name
+    optionwidth = rect.width * 9 / 20
+    pbDrawShadowText(self.contents, rect.x, rect.y, optionwidth, rect.height, optionname,
+       @nameBaseColor, @nameShadowColor)
+    return if index == @options.length
     if @options[index].is_a?(EnumOption)
-      if @options[index].values.length>1
+      if @options[index].values.length > 1
         totalwidth = 0
         for value in @options[index].values
           totalwidth += self.contents.text_size(value).width
         end
-        spacing = (optionwidth-totalwidth)/(@options[index].values.length-1)
-        spacing = 0 if spacing<0
-        xpos = optionwidth+rect.x
+        spacing = (optionwidth - totalwidth) / (@options[index].values.length - 1)
+        spacing = 0 if spacing < 0
+        xpos = optionwidth + rect.x
         ivalue = 0
         for value in @options[index].values
-          pbDrawShadowText(self.contents,xpos,rect.y,optionwidth,rect.height,value,
-             (ivalue==self[index]) ? @selBaseColor : self.baseColor,
-             (ivalue==self[index]) ? @selShadowColor : self.shadowColor
+          pbDrawShadowText(self.contents, xpos, rect.y, optionwidth, rect.height, value,
+             (ivalue == self[index]) ? @selBaseColor : self.baseColor,
+             (ivalue == self[index]) ? @selShadowColor : self.shadowColor
           )
           xpos += self.contents.text_size(value).width
           xpos += spacing
           ivalue += 1
         end
       else
-        pbDrawShadowText(self.contents,rect.x+optionwidth,rect.y,optionwidth,rect.height,
-           optionname,self.baseColor,self.shadowColor)
+        pbDrawShadowText(self.contents, rect.x + optionwidth, rect.y, optionwidth, rect.height,
+           optionname, self.baseColor, self.shadowColor)
       end
     elsif @options[index].is_a?(NumberOption)
-      value = _INTL("Type {1}/{2}",@options[index].optstart+self[index],
-         @options[index].optend-@options[index].optstart+1)
-      xpos = optionwidth+rect.x
-      pbDrawShadowText(self.contents,xpos,rect.y,optionwidth,rect.height,value,
-         @selBaseColor,@selShadowColor)
+      value = _INTL("Type {1}/{2}", @options[index].optstart + self[index],
+         @options[index].optend - @options[index].optstart + 1)
+      xpos = optionwidth + rect.x
+      pbDrawShadowText(self.contents, xpos, rect.y, optionwidth, rect.height, value,
+         @selBaseColor, @selShadowColor)
     elsif @options[index].is_a?(SliderOption)
-      value = sprintf(" %d",@options[index].optend)
-      sliderlength = optionwidth-self.contents.text_size(value).width
-      xpos = optionwidth+rect.x
-      self.contents.fill_rect(xpos,rect.y-2+rect.height/2,
-         optionwidth-self.contents.text_size(value).width,4,self.baseColor)
+      value = sprintf(" %d", @options[index].optend)
+      sliderlength = optionwidth - self.contents.text_size(value).width
+      xpos = optionwidth + rect.x
+      self.contents.fill_rect(xpos, rect.y - 2 + rect.height / 2,
+         optionwidth - self.contents.text_size(value).width, 4, self.baseColor)
       self.contents.fill_rect(
-         xpos+(sliderlength-8)*(@options[index].optstart+self[index])/@options[index].optend,
-         rect.y-8+rect.height/2,
-         8,16,@selBaseColor)
-      value = sprintf("%d",@options[index].optstart+self[index])
-      xpos += optionwidth-self.contents.text_size(value).width
-      pbDrawShadowText(self.contents,xpos,rect.y,optionwidth,rect.height,value,
-         @selBaseColor,@selShadowColor)
+         xpos + (sliderlength - 8) * (@options[index].optstart + self[index]) / @options[index].optend,
+         rect.y - 8 + rect.height / 2,
+         8, 16, @selBaseColor)
+      value = sprintf("%d", @options[index].optstart + self[index])
+      xpos += optionwidth - self.contents.text_size(value).width
+      pbDrawShadowText(self.contents, xpos, rect.y, optionwidth, rect.height, value,
+         @selBaseColor, @selShadowColor)
     else
       value = @options[index].values[self[index]]
-      xpos = optionwidth+rect.x
-      pbDrawShadowText(self.contents,xpos,rect.y,optionwidth,rect.height,value,
-         @selBaseColor,@selShadowColor)
+      xpos = optionwidth + rect.x
+      pbDrawShadowText(self.contents, xpos, rect.y, optionwidth, rect.height, value,
+         @selBaseColor, @selShadowColor)
     end
   end
 
@@ -262,8 +262,8 @@ class Window_PokemonOption < Window_DrawableCommand
     oldindex = self.index
     @mustUpdateOptions = false
     super
-    dorefresh = (self.index!=oldindex)
-    if self.active && self.index<@options.length
+    dorefresh = (self.index != oldindex)
+    if self.active && self.index < @options.length
       if Input.repeat?(Input::LEFT)
         self[self.index] = @options[self.index].prev(self[self.index])
         dorefresh = true
@@ -288,24 +288,24 @@ class PokemonOption_Scene
 
   def pbStartScene(inloadscreen = false)
     @sprites = {}
-    @viewport = Viewport.new(0,0,Graphics.width,Graphics.height)
+    @viewport = Viewport.new(0, 0, Graphics.width, Graphics.height)
     @viewport.z = 99999
     @sprites["title"] = Window_UnformattedTextPokemon.newWithSize(
-       _INTL("Options"),0,0,Graphics.width,64,@viewport)
+       _INTL("Options"), 0, 0, Graphics.width, 64, @viewport)
     @sprites["textbox"] = pbCreateMessageWindow
-    @sprites["textbox"].text           = _INTL("Speech frame {1}.",1+$PokemonSystem.textskin)
+    @sprites["textbox"].text           = _INTL("Speech frame {1}.", 1 + $PokemonSystem.textskin)
     @sprites["textbox"].letterbyletter = false
     pbSetSystemFont(@sprites["textbox"].contents)
     # These are the different options in the game. To add an option, define a
     # setter and a getter for that option. To delete an option, comment it out
     # or delete it. The game's options may be placed in any order.
     @PokemonOptions = [
-       SliderOption.new(_INTL("Music Volume"),0,100,5,
+       SliderOption.new(_INTL("Music Volume"), 0, 100, 5,
          proc { $PokemonSystem.bgmvolume },
          proc { |value|
-           if $PokemonSystem.bgmvolume!=value
+           if $PokemonSystem.bgmvolume != value
              $PokemonSystem.bgmvolume = value
-             if $game_system.playing_bgm!=nil && !inloadscreen
+             if $game_system.playing_bgm != nil && !inloadscreen
                playingBGM = $game_system.getPlayingBGM
                $game_system.bgm_pause
                $game_system.bgm_resume(playingBGM)
@@ -313,12 +313,12 @@ class PokemonOption_Scene
            end
          }
        ),
-       SliderOption.new(_INTL("SE Volume"),0,100,5,
+       SliderOption.new(_INTL("SE Volume"), 0, 100, 5,
          proc { $PokemonSystem.sevolume },
          proc { |value|
-           if $PokemonSystem.sevolume!=value
+           if $PokemonSystem.sevolume != value
              $PokemonSystem.sevolume = value
-             if $game_system.playing_bgs!=nil
+             if $game_system.playing_bgs != nil
                $game_system.playing_bgs.volume = value
                playingBGS = $game_system.getPlayingBGS
                $game_system.bgs_pause
@@ -328,44 +328,44 @@ class PokemonOption_Scene
            end
          }
        ),
-       EnumOption.new(_INTL("Text Speed"),[_INTL("Slow"),_INTL("Normal"),_INTL("Fast")],
+       EnumOption.new(_INTL("Text Speed"), [_INTL("Slow"), _INTL("Normal"), _INTL("Fast")],
          proc { $PokemonSystem.textspeed },
          proc { |value|
            $PokemonSystem.textspeed = value
            MessageConfig.pbSetTextSpeed(MessageConfig.pbSettingToTextSpeed(value))
          }
        ),
-       EnumOption.new(_INTL("Battle Effects"),[_INTL("On"),_INTL("Off")],
+       EnumOption.new(_INTL("Battle Effects"), [_INTL("On"), _INTL("Off")],
          proc { $PokemonSystem.battlescene },
          proc { |value| $PokemonSystem.battlescene = value }
        ),
-       EnumOption.new(_INTL("Battle Style"),[_INTL("Switch"),_INTL("Set")],
+       EnumOption.new(_INTL("Battle Style"), [_INTL("Switch"), _INTL("Set")],
          proc { $PokemonSystem.battlestyle },
          proc { |value| $PokemonSystem.battlestyle = value }
        ),
-       EnumOption.new(_INTL("Default Movement"),[_INTL("Walking"),_INTL("Running")],
+       EnumOption.new(_INTL("Default Movement"), [_INTL("Walking"), _INTL("Running")],
          proc { $PokemonSystem.runstyle },
          proc { |value| $PokemonSystem.runstyle = value }
        ),
-       NumberOption.new(_INTL("Speech Frame"),1,Settings::SPEECH_WINDOWSKINS.length,
+       NumberOption.new(_INTL("Speech Frame"), 1, Settings::SPEECH_WINDOWSKINS.length,
          proc { $PokemonSystem.textskin },
          proc { |value|
            $PokemonSystem.textskin = value
            MessageConfig.pbSetSpeechFrame("Graphics/Windowskins/" + Settings::SPEECH_WINDOWSKINS[value])
          }
        ),
-       NumberOption.new(_INTL("Menu Frame"),1,Settings::MENU_WINDOWSKINS.length,
+       NumberOption.new(_INTL("Menu Frame"), 1, Settings::MENU_WINDOWSKINS.length,
          proc { $PokemonSystem.frame },
          proc { |value|
            $PokemonSystem.frame = value
            MessageConfig.pbSetSystemFrame("Graphics/Windowskins/" + Settings::MENU_WINDOWSKINS[value])
          }
        ),
-       EnumOption.new(_INTL("Text Entry"),[_INTL("Cursor"),_INTL("Keyboard")],
+       EnumOption.new(_INTL("Text Entry"), [_INTL("Cursor"), _INTL("Keyboard")],
          proc { $PokemonSystem.textinput },
          proc { |value| $PokemonSystem.textinput = value }
        ),
-       EnumOption.new(_INTL("Screen Size"),[_INTL("S"),_INTL("M"),_INTL("L"),_INTL("XL"),_INTL("Full")],
+       EnumOption.new(_INTL("Screen Size"), [_INTL("S"), _INTL("M"), _INTL("L"), _INTL("XL"), _INTL("Full")],
          proc { [$PokemonSystem.screensize, 4].min },
          proc { |value|
            if $PokemonSystem.screensize != value
@@ -376,14 +376,14 @@ class PokemonOption_Scene
        )
     ]
     @PokemonOptions = pbAddOnOptions(@PokemonOptions)
-    @sprites["option"] = Window_PokemonOption.new(@PokemonOptions,0,
-       @sprites["title"].height,Graphics.width,
-       Graphics.height-@sprites["title"].height-@sprites["textbox"].height)
+    @sprites["option"] = Window_PokemonOption.new(@PokemonOptions, 0,
+       @sprites["title"].height, Graphics.width,
+       Graphics.height - @sprites["title"].height - @sprites["textbox"].height)
     @sprites["option"].viewport = @viewport
     @sprites["option"].visible  = true
     # Get the values of each option
     for i in 0...@PokemonOptions.length
-      @sprites["option"].setValueNoRefresh(i,(@PokemonOptions[i].get || 0))
+      @sprites["option"].setValueNoRefresh(i, (@PokemonOptions[i].get || 0))
     end
     @sprites["option"].refresh
     pbDeactivateWindows(@sprites)
@@ -397,7 +397,7 @@ class PokemonOption_Scene
   def pbOptions
     oldSystemSkin = $PokemonSystem.frame      # Menu
     oldTextSkin   = $PokemonSystem.textskin   # Speech
-    pbActivateWindow(@sprites,"option") {
+    pbActivateWindow(@sprites, "option") {
       loop do
         Graphics.update
         Input.update
@@ -407,12 +407,12 @@ class PokemonOption_Scene
           for i in 0...@PokemonOptions.length
             @PokemonOptions[i].set(@sprites["option"][i])
           end
-          if $PokemonSystem.textskin!=oldTextSkin
+          if $PokemonSystem.textskin != oldTextSkin
             @sprites["textbox"].setSkin(MessageConfig.pbGetSpeechFrame())
-            @sprites["textbox"].text = _INTL("Speech frame {1}.",1+$PokemonSystem.textskin)
+            @sprites["textbox"].text = _INTL("Speech frame {1}.", 1 + $PokemonSystem.textskin)
             oldTextSkin = $PokemonSystem.textskin
           end
-          if $PokemonSystem.frame!=oldSystemSkin
+          if $PokemonSystem.frame != oldSystemSkin
             @sprites["title"].setSkin(MessageConfig.pbGetSystemFrame())
             @sprites["option"].setSkin(MessageConfig.pbGetSystemFrame())
             oldSystemSkin = $PokemonSystem.frame
@@ -421,7 +421,7 @@ class PokemonOption_Scene
         if Input.trigger?(Input::BACK)
           break
         elsif Input.trigger?(Input::USE)
-          break if @sprites["option"].index==@PokemonOptions.length
+          break if @sprites["option"].index == @PokemonOptions.length
         end
       end
     }