Refactoring and Bugfixes (#127)

* Replacing nil + compact! with delete, delete_at and delete_if wherever possible
* Fixed Terrain Tag editor not setting the correct terrain
* Fixed Text Cursor in Animation Editor not going right

Data/Scripts/020_Debug/003_Debug menus/002_Debug_MenuCommands.rb

@@ -264,8 +264,7 @@ DebugMenuCommands.register("testwildbattleadvanced", {
           scr.pbPokemonDebug(pkmn[pkmnCmd], -1, nil, true)
           scr.pbEndScreen
         elsif pbConfirmMessage(_INTL("Delete this Pokémon?"))
-          pkmn[pkmnCmd] = nil
-          pkmn.compact!
+          pkmn.delete_at(pkmnCmd)
         end
       end
     end
@@ -366,8 +365,7 @@ DebugMenuCommands.register("testtrainerbattleadvanced", {
             trainers[trainerCmd] = [0, tr]
           end
         elsif pbConfirmMessage(_INTL("Delete this trainer?"))
-          trainers[trainerCmd] = nil
-          trainers.compact!
+          trainers.delete_at(trainerCmd)
         end
       end
     end

Data/Scripts/020_Debug/003_Debug menus/005_Debug_PokemonCommands.rb

@@ -1167,8 +1167,7 @@ PokemonDebugMenuCommands.register("delete", {
   "effect"      => proc { |pkmn, pkmnid, heldpoke, settingUpBattle, screen|
     if screen.pbConfirm(_INTL("Are you sure you want to delete this Pokémon?"))
       if screen.is_a?(PokemonPartyScreen)
-        screen.party[pkmnid] = nil
-        screen.party.compact!
+        screen.party.delete_at(pkmnid)
         screen.pbHardRefresh
       elsif screen.is_a?(PokemonStorageScreen)
         screen.scene.pbRelease(pkmnid, heldpoke)