Fixed crashes in debug functions if there's a gap in item ID numbers

This commit is contained in:
Maruno17
2020-09-18 20:22:02 +01:00
parent c391fb39f8
commit f0c0c0a308
2 changed files with 1 additions and 7 deletions

View File

@@ -669,13 +669,6 @@ def pbItemEditorNew(defaultname)
itemdata = pbLoadItemsData itemdata = pbLoadItemsData
# Get the first blank ID for the new item to use. # Get the first blank ID for the new item to use.
maxid = PBItems.maxValue+1 maxid = PBItems.maxValue+1
for i in 1..PBItems.maxValue
name = itemdata[i][1]
if !name || name=="" || itemdata[i][ITEM_POCKET]==0
maxid = i
break
end
end
index = maxid index = maxid
itemname = pbMessageFreeText(_INTL("Please enter the item's name."), itemname = pbMessageFreeText(_INTL("Please enter the item's name."),
(defaultname) ? defaultname.gsub(/_+/," ") : "",false,30) (defaultname) ? defaultname.gsub(/_+/," ") : "",false,30)

View File

@@ -407,6 +407,7 @@ class ItemLister
@itemdata = pbLoadItemsData @itemdata = pbLoadItemsData
cmds = [] cmds = []
for i in 1..PBItems.maxValue for i in 1..PBItems.maxValue
next if !@itemdata[i]
name = @itemdata[i][ITEM_NAME] name = @itemdata[i][ITEM_NAME]
if name && name!="" && @itemdata[i][ITEM_POCKET]!=0 if name && name!="" && @itemdata[i][ITEM_POCKET]!=0
cmds.push([i,name]) cmds.push([i,name])