Removed unnecessary text drawing in Options screen, misc tweaks

Data/Scripts/009_Objects and windows/003_SpriteWindow.rb

@@ -384,27 +384,27 @@ end
 
 # Sets a bitmap's font to the system font.
 def pbSetSystemFont(bitmap)
-  fontname=MessageConfig.pbGetSystemFontName
-  bitmap.font.name=fontname
-  if fontname=="Pokemon FireLeaf" || fontname=="Power Red and Green"
-    bitmap.font.size=29
-  elsif fontname=="Pokemon Emerald Small" || fontname=="Power Green Small"
-    bitmap.font.size=25
+  fontname = MessageConfig.pbGetSystemFontName
+  bitmap.font.name = fontname
+  if fontname == "Pokemon FireLeaf" || fontname == "Power Red and Green"
+    bitmap.font.size = 29
+  elsif fontname == "Pokemon Emerald Small" || fontname == "Power Green Small"
+    bitmap.font.size = 25
   else
-    bitmap.font.size=31
+    bitmap.font.size = 31
   end
 end
 
 # Sets a bitmap's font to the system small font.
 def pbSetSmallFont(bitmap)
-  bitmap.font.name=pbSmallFontName
-  bitmap.font.size=25
+  bitmap.font.name = pbSmallFontName
+  bitmap.font.size = 25
 end
 
 # Sets a bitmap's font to the system narrow font.
 def pbSetNarrowFont(bitmap)
-  bitmap.font.name=pbNarrowFontName
-  bitmap.font.size=31
+  bitmap.font.name = pbNarrowFontName
+  bitmap.font.size = 31
 end
 
 #===============================================================================

Data/Scripts/010_Scenes/005_Scene_Credits.rb

@@ -127,7 +127,7 @@ _END_
       end
       plugin_credits << "\n"
     end
-    CREDIT.gsub!(/{INSERTS_PLUGIN_CREDITS_DO_NOT_REMOVE}/, plugin_credits)
+    CREDIT.gsub!(/\{INSERTS_PLUGIN_CREDITS_DO_NOT_REMOVE\}/, plugin_credits)
     credit_lines = CREDIT.split(/\n/)
     credit_bitmap = Bitmap.new(Graphics.width,32 * credit_lines.size)
     credit_lines.each_index do |i|

Data/Scripts/012_Battle/005_Battle scene/005_PokeBattle_SceneMenus.rb

@@ -413,14 +413,16 @@ class FightMenuDisplay < BattleMenuBase
 
   def refreshMegaEvolutionButton
     return if !USE_GRAPHICS
-    @megaButton.src_rect.y = (@mode-1)*@megaEvoBitmap.height/2
-    @megaButton.z          = self.z - 1
+    @megaButton.src_rect.y    = (@mode - 1) * @megaEvoBitmap.height / 2
+    @megaButton.z             = self.z - 1
+    @visibility["megaButton"] = (@mode > 0)
   end
 
   def refreshShiftButton
     return if !USE_GRAPHICS
-    @shiftButton.src_rect.y = (@shiftMode-1)*@shiftBitmap.height
-    @shiftButton.z          = self.z - 1
+    @shiftButton.src_rect.y    = (@shiftMode - 1) * @shiftBitmap.height
+    @shiftButton.z             = self.z - 1
+    @visibility["shiftButton"] = (@shiftMode > 0)
   end
 
   def refresh

Data/Scripts/017_UI/015_PScreen_Options.rb

@@ -333,7 +333,6 @@ class Window_PokemonOption < Window_DrawableCommand
     optionwidth = rect.width*9/20
     pbDrawShadowText(self.contents,rect.x,rect.y,optionwidth,rect.height,optionname,
        @nameBaseColor,@nameShadowColor)
-    self.contents.draw_text(rect.x,rect.y,optionwidth,rect.height,optionname)
     return if index==@options.length
     if @options[index].is_a?(EnumOption)
       if @options[index].values.length>1
@@ -350,7 +349,6 @@ class Window_PokemonOption < Window_DrawableCommand
              (ivalue==self[index]) ? @selBaseColor : self.baseColor,
              (ivalue==self[index]) ? @selShadowColor : self.shadowColor
           )
-          self.contents.draw_text(xpos,rect.y,optionwidth,rect.height,value)
           xpos += self.contents.text_size(value).width
           xpos += spacing
           ivalue += 1
@@ -384,7 +382,6 @@ class Window_PokemonOption < Window_DrawableCommand
       xpos = optionwidth+rect.x
       pbDrawShadowText(self.contents,xpos,rect.y,optionwidth,rect.height,value,
          @selBaseColor,@selShadowColor)
-      self.contents.draw_text(xpos,rect.y,optionwidth,rect.height,value)
     end
   end
 

Data/Scripts/022_Compiler/001_Compiler.rb

@@ -1167,15 +1167,15 @@ def pbCompileAllData(mustCompile)
     yield(_INTL("Compiling shadow move data"))
     pbCompileShadowMoves
     yield(_INTL("Compiling messages"))
+    pbCompileAnimations
+    pbCompileTrainerEvents(mustCompile)
+    pbSetTextMessages
+    MessageTypes.saveMessages
   else
     if (!$INEDITOR || LANGUAGES.length<2) && safeExists?("Data/messages.dat")
       MessageTypes.loadMessageFile("Data/messages.dat")
     end
   end
-  pbCompileAnimations
-  pbCompileTrainerEvents(mustCompile)
-  pbSetTextMessages
-  MessageTypes.saveMessages
   if !$INEDITOR && LANGUAGES.length>=2
     pbLoadMessages("Data/"+LANGUAGES[$PokemonSystem.language][1])
   end