More AI function codes, tweaked AI score threshold, renumbered all PBEffects constants

Data/Scripts/011_Battle/005_AI/004_AI_ChooseMove.rb

@@ -6,7 +6,7 @@ class Battle::AI
   # Returns a value between 0.0 and 1.0. All move scores are lowered by this
   # value multiplied by the highest-scoring move's score.
   def move_score_threshold
-    return 0.6 + 0.35 * (([@trainer.skill, 100].min / 100.0) ** 0.5)   # 0.6 to 0.95
+    return 0.6 + 0.3 * (([@trainer.skill, 100].min / 100.0) ** 0.5)   # 0.6 to 0.9
   end
 
   #=============================================================================
@@ -147,8 +147,8 @@ class Battle::AI
       move.pbOnStartUse(@user.battler, [])   # Determine which move is used instead
       move = Battle::Move.from_pokemon_move(@battle, Pokemon::Move.new(move.npMove))
     end
-    @move.set_up(move)
     @battle.moldBreaker = @user.has_mold_breaker?
+    @move.set_up(move)
   end
 
   def set_up_move_check_target(target)
@@ -158,6 +158,7 @@ class Battle::AI
       if @target.battler.lastRegularMoveUsed &&
          GameData::Move.get(@target.battler.lastRegularMoveUsed).has_flag?("CanMirrorMove")
         mov = Battle::Move.from_pokemon_move(@battle, Pokemon::Move.new(@target.battler.lastRegularMoveUsed))
+        @battle.moldBreaker = @user.has_mold_breaker?
         @move.set_up(mov)
       end
     end
@@ -291,7 +292,7 @@ class Battle::AI
   # TODO: The above also applies if the move is Heal Pulse or a few other moves
   #       like that, which CAN target a foe but you'd never do so. Maybe use a
   #       move flag to determine such moves? The implication is that such moves
-  #       wouldn't apply the "175 - score" bit, which would make their
+  #       wouldn't apply the "185 - score" bit, which would make their
   #       MoveHandlers do the opposite calculations to other moves with the same
   #       targets, but is this desirable?
   #=============================================================================
@@ -322,7 +323,7 @@ class Battle::AI
       end
       # TODO: Is this reversal of the score okay?
       old_score = score
-      score = 175 - score
+      score = 185 - score
       PBDebug.log_score_change(score - old_score, "score inverted (move targets ally but can target foe)")
     end
     return score

Data/Scripts/011_Battle/005_AI/102_AIBattler.rb

@@ -299,6 +299,59 @@ class Battle::AI::AIBattler
     return false
   end
 
+  # NOTE: This specifically means "is not currently trapped but can become
+  #       trapped by an effect". Similar to def pbCanSwitchOut? but this returns
+  #       false if any certain switching OR certain trapping applies.
+  def can_become_trapped?
+    return false if fainted?
+    # Ability/item effects that allow switching no matter what
+    if ability_active? && Battle::AbilityEffects.triggerCertainSwitching(ability, @battler, @ai.battle)
+      return false
+    end
+    if item_active? && Battle::ItemEffects.triggerCertainSwitching(item, @battler, @ai.battle)
+      return false
+    end
+    # Other certain switching effects
+    return false if Settings::MORE_TYPE_EFFECTS && has_type?(:GHOST)
+    # Other certain trapping effects
+    return false if @battler.trappedInBattle?
+    # Trapping abilities/items
+    ai.each_foe_battler(side) do |b, i|
+      if b.ability_active? &&
+         Battle::AbilityEffects.triggerTrappingByTarget(b.ability, @battler, b.battler, @ai.battle)
+        return false
+      end
+      if b.item_active? &&
+         Battle::ItemEffects.triggerTrappingByTarget(b.item, @battler, b.battler, @ai.battle)
+        return false
+      end
+    end
+    return true
+  end
+
+  #=============================================================================
+
+  def wants_status_problem?(new_status)
+    return true if new_status == :NONE
+    if ability_active?
+      case ability_id
+      when :GUTS
+        return true if stat_raise_worthwhile?(self, :ATTACK, true)
+      when :MARVELSCALE
+        return true if stat_raise_worthwhile?(self, :DEFENSE, true)
+      when :QUICKFEET
+        return true if stat_raise_worthwhile?(self, :SPEED, true)
+      when :FLAREBOOST
+        return true if new_status == :BURN && stat_raise_worthwhile?(self, :SPECIAL_ATTACK, true)
+      end
+    end
+    return true if new_status == :SLEEP && check_for_move { |m| m.usableWhenAsleep? }
+    if has_move_with_function?("DoublePowerIfUserPoisonedBurnedParalyzed")
+      return true if [:POISON, :BURN, :PARALYSIS].include?(new_status)
+    end
+    return false
+  end
+
   #=============================================================================
 
   # TODO: Add more items.

Data/Scripts/011_Battle/005_AI/103_AIMove.rb

@@ -11,6 +11,8 @@ class Battle::AI::AIMove
   def set_up(move)
     @move = move
     @move.calcType = rough_type
+    @ai.battle.moldBreaker ||= ["IgnoreTargetAbility",
+                                "CategoryDependsOnHigherDamageIgnoreTargetAbility"].include?(function)
   end
 
   #=============================================================================